Core: Fix module guard in non-webpack environments
#22085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
shilman
changed the title
module usage in non-webpack environments
shilman
changed the title
module usage in non-webpack environmentsmodule guard in non-webpack environments
ndelangen
approved these changes
Apr 17, 2023
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Apr 18, 2023
Core: Fix `module` guard in non-webpack environments
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22046
What I did
Ensure
modulevariable actually exists every place that it is used.How to test
I don't have a repro, so can't easily test. However, I think this is a safe check. @ndelangen WDYT?