Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): removing deprecated import to fix storyshots #22134

Merged
merged 3 commits into from
Apr 27, 2023
Merged

fix(angular): removing deprecated import to fix storyshots #22134

merged 3 commits into from
Apr 27, 2023

Conversation

manbearwiz
Copy link
Contributor

Closes #21652

What I did

Update import from core-client to preview-api. Seems like this was missed as part of PR #19749.

This was causing the warning importing from @storybook/core-client is deprecated and will be removed in 8.0, please import canvas related modules from @storybook/preview-api and error TypeError: Cannot read properties of undefined (reading 'clientApi') when running storyshots.

How to test

I tested via linking to a working project. I probably can come up with a minimum reproduction case if need be, but Angular + Jest + Storyshots is sorta an interesting configuration and runs take a long time.

-->

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@manbearwiz
Copy link
Contributor Author

Rebased

@valentinpalkovic
Copy link
Contributor

Hi @manbearwiz,

Thank you so much for your contribution. Might you resolve the conflicts. I will merge the PR then as soon as the pipeline is green.

@manbearwiz
Copy link
Contributor Author

@valentinpalkovic rebased again. Should be good to go now.

@manbearwiz
Copy link
Contributor Author

It looks like e2e tests are failing, any insight into that? they are using the cra sandbox, the change in this PR shouldn't affect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: Cannot read properties of undefined (reading 'clientApi')
3 participants