Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate @storybook/addon-outline to strict TS #22369

Merged
merged 3 commits into from
May 4, 2023
Merged

Migrate @storybook/addon-outline to strict TS #22369

merged 3 commits into from
May 4, 2023

Conversation

kyletsang
Copy link
Contributor

Part of #22176

What I did

Migrate @storybook/addon-outline to strict TS. There was nothing to do other than set strict to true in tsconfig

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 3, 2023
@kasperpeulen kasperpeulen self-requested a review May 3, 2023 14:37
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen merged commit e9afed3 into storybookjs:next May 4, 2023
@jonniebigodes
Copy link
Contributor

@kyletsang, one thing left to address as part of this initiative and the amazing work you did by helping us convert Storybook's packages to allow stricter TypeScript support. If you're ok with it, can you message me on our Discord server ( same username) so that I can follow up with you?

Hope you have a fantastic day.

Stay safe

@kyletsang kyletsang deleted the outline-ts branch July 25, 2023 19:49
@kyletsang
Copy link
Contributor Author

Hi @jonniebigodes unfortunately, discord is not letting me join the server without entering a phone number, and I rather not do that. I've sent you a friend request so you can DM me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants