-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Detach automigrate command from storybook init #22523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
maintenance
User-facing maintenance tasks
cli
patch:yes
Bugfix & documentation PR that need to be picked to main branch
labels
May 11, 2023
shilman
reviewed
May 12, 2023
shilman
reviewed
May 12, 2023
yannbf
force-pushed
the
feat/detach-automigrate-from-init
branch
from
May 12, 2023 07:47
2fa9ff7
to
4eb0401
Compare
valentinpalkovic
approved these changes
May 12, 2023
Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
valentinpalkovic
approved these changes
May 12, 2023
This was referenced May 15, 2023
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
May 15, 2023
shilman
pushed a commit
that referenced
this pull request
May 15, 2023
…om-init CLI: Detach automigrate command from storybook init
This was referenced May 15, 2023
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
maintenance
User-facing maintenance tasks
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22346
What I did
storybook init
anymoreText formatting isn't amazing but we plan on revamping the CLI to use something else and more beautiful in the future, I guess we can cope with it for now!
How to test
storybook init
command in those:a. react-webpack - should add babel config file
b. nextjs - should suggest ESLint plugin and change the eslint config file
c. cra - should suggest ESLint plugin and change config in package.json
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]