Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start-storybook: suggest an alternative when the port is occupied #4146

Merged
merged 3 commits into from
Sep 8, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: All this EADDRINUSE stuff

How to test

Run yarn start in two parallel terminal tabs

? Port 9011 is not available.
Would you like to run Storybook on port 9012 instead? (Y/n) 

This also makes -p argument optional

@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #4146 into master will increase coverage by 48.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4146       +/-   ##
===========================================
+ Coverage   40.49%   88.63%   +48.13%     
===========================================
  Files         491        6      -485     
  Lines        5835       44     -5791     
  Branches      791        2      -789     
===========================================
- Hits         2363       39     -2324     
+ Misses       3085        4     -3081     
+ Partials      387        1      -386
Impacted Files Coverage Δ
...toryshots-core/src/frameworks/svelte/renderTree.js
addons/backgrounds/mithril.js
app/riot/src/client/preview/render-riot.js
addons/knobs/src/components/types/Select.js
...yshots/storyshots-core/src/frameworks/rn/loader.js
addons/storysource/src/loader/parsers/index.js
lib/ui/src/modules/ui/configs/handle_routing.js
...ents/stories_panel/stories_tree/tree_decorators.js
...-native/src/preview/components/OnDeviceUI/style.js
lib/core/src/server/config.js
... and 474 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839fda4...6606625. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants