Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onDeviceUI] Adding on device addons. #4327

Merged
merged 3 commits into from
Oct 12, 2018
Merged

[onDeviceUI] Adding on device addons. #4327

merged 3 commits into from
Oct 12, 2018

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Oct 9, 2018

This PR is part of #3903.

This adds 3 on device addons: Notes, Knobs, Backgrounds.
They are definitely not the cleanest and up to date addons.

Looking forward @ndelangen suggested that we have to think of the way to display addons as webviews in the app. But for now these are good enough to display that we can have addons in the app.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly versions mismatch.

@@ -0,0 +1,33 @@
{
"name": "@storybook/addon-ondevice-backgrounds",
"version": "4.0.0-alpha.20",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed the version update

"prepare": "node ../../scripts/prepare.js"
},
"dependencies": {
"@storybook/addons": "4.0.0-alpha.20",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like everywhere

},
"dependencies": {
"@storybook/addons": "4.0.0-alpha.20",
"@storybook/addon-knobs": "4.0.0-alpha.20",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't get where this in use

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A person who uses ondevice-knobs will be still importing addon-knobs inside their app. So if he doesn't install it directly we still want him to have it in his node_modules. @igor-dv.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but users will need to install it explicitly. In that case, you probably want it to be a peer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks :)

"prop-types": "^15.6.2",
"react-native-color-picker": "^0.4.0",
"react-native-modal-datetime-picker": "^5.1.0",
"react-native-modal-selector": "0.0.27",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be stuck to the exact version?

@Gongreg
Copy link
Member Author

Gongreg commented Oct 10, 2018

Nothing seems to be blocking this PR too @ndelangen, @igor-dv.

@igor-dv
Copy link
Member

igor-dv commented Oct 10, 2018

Let's merge if after the #3903 is ready? We won't use addons without the support for addons, right?

@Gongreg
Copy link
Member Author

Gongreg commented Oct 10, 2018

Sure.

@ndelangen
Copy link
Member

merge when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants