chore(core): update css-loader to latest #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get latest from storybook
merge 4.0.0-rc.1 into local
Update from latest master
…ve lodash dependencies
Codecov Report
@@ Coverage Diff @@
## master #4619 +/- ##
=======================================
Coverage 35.59% 35.59%
=======================================
Files 557 557
Lines 6732 6732
Branches 884 884
=======================================
Hits 2396 2396
Misses 3876 3876
Partials 460 460Continue to review full report at Codecov.
|
igor-dv
approved these changes
Oct 30, 2018
igor-dv
reviewed
Oct 30, 2018
lib/core/package.json
Outdated
| @@ -47,7 +47,7 @@ | |||
| "commander": "^2.19.0", | |||
| "common-tags": "^1.8.0", | |||
| "core-js": "^2.5.7", | |||
| "css-loader": "^1.0.0", | |||
| "css-loader": "^1.0.1", | |||
There was a problem hiding this comment.
Looks like css-loader is used in some other packages too. Can you update it there as well?
There was a problem hiding this comment.
Sure thing, happy to!
…dency CVE on lodash modularized packages
Stephanemw
requested review from
Hypnosphi,
ndelangen,
shilman and
stijnkoopal
as code owners
update from master
update from master
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
css-loader 1.0.0 depends on vulnerable versions of lodash packages
What I did
updated to latest css-loader that addresses these transitive dependency issues
How to test
yarn test