-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes component imports from dist #4682
Conversation
I will combine this with angular cli projects in order to have a direct test of this change |
@kroeder I would keep these PRs separate |
Alright 👍 |
Codecov Report
@@ Coverage Diff @@
## master #4682 +/- ##
=======================================
Coverage 35.59% 35.59%
=======================================
Files 557 557
Lines 6732 6732
Branches 884 884
=======================================
Hits 2396 2396
Misses 3876 3876
Partials 460 460
Continue to review full report at Codecov.
|
Issue: N/A
What I did
There was a bug with the webpack plugin
TsconfigPathsPlugin
where Storybook in Angular could not import angular components when they are built.This was my test scenario
After checking the angular values here: https://github.com/angular/angular-cli/blob/9f114aee1e009c3580784dd3bb7299bdf4a5918c/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/server.ts#L21
I added
How to test
link
this change into the app and start storybook again, should work