-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addons Jest - Fix test matching #4689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4689 +/- ##
==========================================
- Coverage 35.59% 35.57% -0.03%
==========================================
Files 557 557
Lines 6732 6736 +4
Branches 884 886 +2
==========================================
Hits 2396 2396
- Misses 3876 3878 +2
- Partials 460 462 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. are there any tests for this?
We can see this working in preview https://deploy-preview-4689--storybooks-official.netlify.com/?selectedKind=Addons%7Cjest&selectedStory=withTests&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Ftests%2Fpanel But I will add some unit tests anyway. Maybe as a separate PR |
Addons Jest - Fix test matching
Issue: #4497
What I did