Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SB deps from cli tests #4705

Merged
merged 6 commits into from
Nov 5, 2018
Merged

Remove SB deps from cli tests #4705

merged 6 commits into from
Nov 5, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Nov 3, 2018

Issue: #4590 findings

What I did

  1. removed SB deps from the cli tests
  2. changed a few forgotten deps to 4.0.0

@igor-dv igor-dv added dependencies maintenance User-facing maintenance tasks labels Nov 3, 2018
@igor-dv igor-dv self-assigned this Nov 3, 2018
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (next@5625a39). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #4705   +/-   ##
=======================================
  Coverage        ?   35.51%           
=======================================
  Files           ?      557           
  Lines           ?     6741           
  Branches        ?      889           
=======================================
  Hits            ?     2394           
  Misses          ?     3884           
  Partials        ?      463

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5625a39...9b7dc35. Read the comment docs.

@igor-dv igor-dv changed the base branch from master to next November 5, 2018 16:54
@igor-dv igor-dv added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants