Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NODE_PATH is not being loaded from .env #4706

Merged
merged 7 commits into from
Nov 12, 2018
Merged

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Nov 3, 2018

Issue: based on the changes from #4590
Fixes: #4496

  1. I've added a NODE_PATH=src into the .env in cra-kitchen-sink
  2. Separated the main jest.config.js into examples

@Hypnosphi Hypnosphi changed the base branch from master to next November 5, 2018 17:04
@igor-dv igor-dv added ci: do not merge patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 5, 2018
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #4706 into next will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #4706      +/-   ##
==========================================
- Coverage   35.48%   35.45%   -0.03%     
==========================================
  Files         557      557              
  Lines        6747     6752       +5     
  Branches      892      892              
==========================================
  Hits         2394     2394              
- Misses       3887     3892       +5     
  Partials      466      466
Impacted Files Coverage Δ
lib/core/src/server/config/webpack.config.prod.js 0% <0%> (ø) ⬆️
lib/core/src/server/config/utils.js 0% <0%> (ø) ⬆️
lib/core/src/server/config/webpack.config.dev.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0492f...f094002. Read the comment docs.

@ndelangen ndelangen added this to the next milestone Nov 8, 2018
@igor-dv
Copy link
Member Author

igor-dv commented Nov 8, 2018

Looks like storyshots are not executed now 🤔

@ndelangen
Copy link
Member

@igor-dv Is this ready to merge?

@igor-dv
Copy link
Member Author

igor-dv commented Nov 10, 2018

It's ready, but I've changed a bit the script/test.js, would like to know if it's an acceptable change, or not.
CC @Hypnosphi

@igor-dv igor-dv merged commit 33ed8d9 into next Nov 12, 2018
@igor-dv igor-dv deleted the node-path-loading-fix branch November 12, 2018 10:43
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants