Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4665: set correct cache directory path #4792

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

alex-fournier
Copy link
Contributor

Issue: #4665

What I did

Use find-cache-dir (instead of current directory by default) to setup basePath for cache file in build-dev script.

This allows to store cache file in node_modules/.cache instead of the root folder of the project.

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #4792 into next will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #4792      +/-   ##
==========================================
- Coverage   35.56%   35.55%   -0.02%     
==========================================
  Files         560      560              
  Lines        6808     6810       +2     
  Branches      911      910       -1     
==========================================
  Hits         2421     2421              
- Misses       3911     3914       +3     
+ Partials      476      475       -1
Impacted Files Coverage Δ
lib/core/src/server/build-dev.js 0% <0%> (ø) ⬆️
lib/core/src/server/dev-server.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93fa286...31250b1. Read the comment docs.

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

@ndelangen ndelangen self-assigned this Nov 16, 2018
@ndelangen ndelangen added maintenance User-facing maintenance tasks core labels Nov 16, 2018
@ndelangen ndelangen added this to the next milestone Nov 16, 2018
@ndelangen ndelangen merged commit e11617c into storybookjs:next Nov 16, 2018
@ndelangen
Copy link
Member

Thanks @alex-fournier this is perfect!

@alex-fournier alex-fournier deleted the fix-cache-directory branch November 16, 2018 16:04
@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch and removed maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch labels Nov 21, 2018
shilman pushed a commit that referenced this pull request Nov 25, 2018
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants