Clear build folder in static build #6024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should clear the output folder completely and then only copy the defaultFavIcon once. This allows the use of plugins like CopyWebpackPlugin to work as expected (otherwise what it copies is never removed on future builds).
CurtisHumphrey
requested review from
alterx,
igor-dv and
tmeasday
as code owners
shilman
added
bug
cli
patch:yes
shilman
approved these changes
Mar 11, 2019
|
@ndelangen pls review .. seems like a big change & i'm not sure why the old code was that way |
wuweiweiwu
approved these changes
Mar 16, 2019
shilman
changed the title
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The static site building did not completely clear the build folder. This causes issues with additional plugins like CopyWebpackPlugin because once a file was added it was never removed.
What I did
Changed the logic to completely clear the output dir and cleaned up so that it only copies the defaultFavIcon once.
How to test
test.html.