-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: open brandUrl in new window #6106
UI: open brandUrl in new window #6106
Conversation
Codecov Report
@@ Coverage Diff @@
## next #6106 +/- ##
=========================================
- Coverage 37.1% 35.79% -1.32%
=========================================
Files 648 648
Lines 9524 9521 -3
Branches 1381 1352 -29
=========================================
- Hits 3534 3408 -126
- Misses 5411 5536 +125
+ Partials 579 577 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! one feature-request and then this will get merged:
Please only add the target when the url is an external link.
@ndelangen |
If target is an empty string, Not having the prop at all seems a bit cleaner to me, but this is good to merge IMHO! Good addition @toshi1127 👍 |
Issue: #6070
What I did
Opened brandUrl in new window when the brand image was clicked
How to test