Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE lib/theming so it no longer depends on react-inspector #6818

Merged
merged 4 commits into from
May 20, 2019

Conversation

ndelangen
Copy link
Member

Issue: #6764

What I did

COPY the chromeDark & chromeLight variables into the module itself

COPY the chromeDark & chromeLight variables into the module itself
@ndelangen ndelangen added this to the 5.1.0 milestone May 18, 2019
@ndelangen ndelangen self-assigned this May 18, 2019
@vercel
Copy link

vercel bot commented May 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-dep-of-syntax-themes.storybook.now.sh

@ndelangen
Copy link
Member Author

This adds the code for theming the syntaxhighlighter into lib/theming instead of pulling it from react-inspector.

We might want to create packages for these themes, so we can share this code again.

If anyone would be interested in creating those packages?

@ndelangen
Copy link
Member Author

@beauroberts could you help us review this?

Copy link

@beauroberts beauroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I suspect the actual source of the error I encountered might reside in addon-actions:

ActionLogger imports Inspector from storybooks/react-inspector. The different inspector implementations (DOMInspector, ObjectInspector) import TreeView, which makes use of hooks and memo, both unavailable in React < 16.6, (or 16.8 in the case of hooks).

But this will probably sort my issue if I remove use of the Actions addon. Thank you!

@ndelangen ndelangen merged commit 19ea1f2 into next May 20, 2019
@ndelangen ndelangen deleted the fix/dep-of-syntax-themes branch May 20, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants