-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGE lib/theming so it no longer depends on react-inspector #6818
Conversation
COPY the chromeDark & chromeLight variables into the module itself
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-dep-of-syntax-themes.storybook.now.sh |
This adds the code for theming the syntaxhighlighter into lib/theming instead of pulling it from react-inspector. We might want to create packages for these themes, so we can share this code again. If anyone would be interested in creating those packages? |
@beauroberts could you help us review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I suspect the actual source of the error I encountered might reside in addon-actions
:
ActionLogger
imports Inspector
from storybooks/react-inspector
. The different inspector implementations (DOMInspector
, ObjectInspector
) import TreeView
, which makes use of hooks and memo
, both unavailable in React < 16.6, (or 16.8 in the case of hooks).
But this will probably sort my issue if I remove use of the Actions addon. Thank you!
Issue: #6764
What I did
COPY the chromeDark & chromeLight variables into the module itself