Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-Time IPA Expiry Tagging in Dispute Module #68

Closed
kingster-will opened this issue Apr 11, 2024 · 2 comments
Closed

Real-Time IPA Expiry Tagging in Dispute Module #68

kingster-will opened this issue Apr 11, 2024 · 2 comments
Assignees

Comments

@kingster-will
Copy link

Please the requirements https://www.notion.so/storyprotocol/Expiration-Term-PIL-9e1c3b3945b74d10987dae6eafc245bb?pvs=4

Here's the revised text with corrections and improvements to the syntax and phrasing:

The dispute module needs to support tagging of expired IPAs. Both the Royalty Module and the Licensing Module should verify the tag. To set and verify the expiration through the DisputeModule, consider the following approach:
We can introduce a new function in the DisputeModule called checkTagAndExpiration(address ipId) returns (bool). This function will verify existing tags and also check the expiration of the IPA, applying an "EXPIRED" tag if the IPA has expired.
Subsequently, all other functions or external applications should call this function before proceeding with their operations. This ensures that the tagging remains up-to-date and reflective of real-time status.

@jdubpark
Copy link

Noting that a public checkTagAndExpiration with a side effect (setting a dispute tag) means external contracts can't use it in view functions, which reduces composability (if we expect this to be called by external contracts too).

@Spablob
Copy link

Spablob commented Apr 12, 2024

I guess I would need to know on licensing side @kingster-will :

  1. which licensing side functions need the expiration restriction?
  2. since the time only starts on burning a license in which licensing side function should the timer start?
  3. (not sure) is there a way to register a IPAsset without burning the license? If there is, how can we prevent people to circumvent the expiration time when they don't burn the license?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants