You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have to inherit from ERC6551 and override _isValidSigner() to use our AccessController
If we use the upgradeable version, it will also use isValidSigner(). We have to be SUPER careful with AccessController in this context, we may have to parse if the call is part of an upgrade from msg.data
The text was updated successfully, but these errors were encountered:
To migrate to Solady's ERC6551, might need to add two parameters, target and data in _isValidSigner() of Solady's ERC6551.
Currently, _isValidSigner() in Solady's ERC6551 only accepts one parameter, signer.
function _isValidSigner(addresssigner) internalviewvirtualreturns (bool) {
return signer ==owner();
}
However, _isValidSigner() in IPAccountImpl needs two more parameters, to(i.e., target) and data, in order to check permission with AccessContoller.
/// @dev Checks if the signer is valid for the given data and recipient via the AccessController permission system./// @param signer The signer to check/// @param to The recipient of the transaction/// @param data The calldata to check against/// @return bool is true if the signer is valid, false otherwisefunction _isValidSigner(addresssigner, addressto, bytescalldatadata) internalviewreturns (bool) {...}
_isValidSigner()
to use our AccessControllerThe text was updated successfully, but these errors were encountered: