Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Periphery Contracts to Use executeWithSig for Direct Function Calls #110

Open
sebsadface opened this issue Nov 1, 2024 · 0 comments
Open

Refactor Periphery Contracts to Use executeWithSig for Direct Function Calls #110

sebsadface opened this issue Nov 1, 2024 · 0 comments
Assignees
@sebsadface
Labels
enhancement New feature or request

Comments

@sebsadface
Copy link
Member

Description

Currently, periphery contracts set permissions before invoking core protocol functions. For example, before DerivativeWorkflows calls registerDerivative in the LicensingModule, it first sets permissions to allow the function call using a user-provided signature, and then calls registerDerivative. This approach is less gas-efficient and could introduce potential security vulnerabilities.

Proposed Solution

Migrate to using executeWithSig from IPAccount to directly call the target function, thereby eliminating the intermediate permission-setting step.
@sebsadface sebsadface self-assigned this Nov 1, 2024
@sebsadface sebsadface added the enhancement New feature or request label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebsadface sebsadface

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebsadface