Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with Solady's ERC6551 Implementation #28

Closed
sebsadface opened this issue Aug 18, 2024 · 0 comments
Closed

Integration with Solady's ERC6551 Implementation #28

sebsadface opened this issue Aug 18, 2024 · 0 comments
Assignees
@sebsadface

Comments

@sebsadface
Copy link
Member

Description

SPG tests are failing due to changes in protocol-core-v1, which integrated Solady's ERC6551 implementation (see protocol-core-v1 #133). The update changes the uint256 nonce to a state variable that is now computed from the input parameters of the execute() function. The tests' signature generation needs to be updated to align with these protocol changes.
@sebsadface sebsadface self-assigned this Aug 18, 2024
@sebsadface sebsadface changed the title Integration with Solday's ERC6551 Implementation Integration with Solady's ERC6551 Implementation Aug 18, 2024
@sebsadface sebsadface mentioned this issue Aug 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebsadface sebsadface

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebsadface