Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DerivativeWorkflows by Removing Minting Fee Handling #71

Open
sebsadface opened this issue Sep 19, 2024 · 0 comments
Open

Simplify DerivativeWorkflows by Removing Minting Fee Handling #71

sebsadface opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sebsadface
Copy link
Member

Description

Currently, the DerivativeWorkflows contract fetches the minting fee from the core protocol and requires users to transfer this fee to DerivativeWorkflows, which then passes it on to the royalty module. This workaround was necessary because there was no straightforward way for the application to fetch the minting fee directly from the core protocol, preventing users from knowing the exact fee at signing time (see issue #21).

With the recent addition of the predictMintingLicenseFee view function in the core protocol (as outlined in PR #200, the application can now retrieve the latest minting fee in a single function call. This allows users to approve the minting fee directly to the royalty module.

Proposal:

  • Remove the logic in DerivativeWorkflows that fetches the minting fee and handles token transfers.
  • Assume that the minting fee is already approved to the royalty module when registering derivatives.

Benefits:

  • Simplifies the derivative registration workflow.
  • Reduces gas costs for derivative registration functions.
@sebsadface sebsadface self-assigned this Sep 19, 2024
@sebsadface sebsadface added the enhancement New feature or request label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant