Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying SPGNFT with the New Story NFT Framework #96

Open
sebsadface opened this issue Oct 14, 2024 · 0 comments
Open

Unifying SPGNFT with the New Story NFT Framework #96

sebsadface opened this issue Oct 14, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sebsadface
Copy link
Member

Description and Context

The existing SPGNFT implementation is incompatible with the new Story NFT framework (BaseStoryNFT, StoryNFTFactory, OrgNFT). Currently, SPGNFT is too rigid and relies heavily on workflow contracts for interacting with the core protocol. To improve SPGNFT and align it with the new framework, we propose modifying SPGNFT to be part of Story NFT collections and make it the default NFT template for interacting with the PoC core protocol.

Suggested Solution

  • Refactor SPGNFT to inherit from BaseStoryNFT, and incorporate essential core-protocol features (e.g., IP registration) directly within the contract.
  • Integrate SPGNFT with the Story NFT Factory, and allows users to deploy new collections.
  • Update the existing workflow contracts to accommodate changes introduced in the new SPGNFT implementation
@sebsadface sebsadface added the enhancement New feature or request label Oct 14, 2024
@sebsadface sebsadface self-assigned this Oct 14, 2024
@sebsadface sebsadface changed the title Unifying `SPGNFT with the New Story NFT Framework Unifying SPGNFT with the New Story NFT Framework Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant