Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the wasm cache if pod is crashlooping #300

Closed
DavidNix opened this issue Jun 1, 2023 · 5 comments
Closed

Delete the wasm cache if pod is crashlooping #300

DavidNix opened this issue Jun 1, 2023 · 5 comments

Comments

@DavidNix
Copy link
Contributor

DavidNix commented Jun 1, 2023

This gets into a larger self-healing feature of crashloop mitigation.

See: CosmWasm/wasmvm#426

We could delete the cache on every restart, but I'm unsure how it will affect performance. Per the above, there will be a "slowdown".

@webmaster128
Copy link

We could delete the cache on every restart, but I'm unsure how it will affect performance. Per the above, there will be a "slowdown".

I'd definitely recommend against that. You'd have to re-compile Wasm -> native for each contract after every start.

If you do it once per chain upgrade, that's safe enough. But at the end of the day that's a CosmWasm bug that will be fixed in 1.3 and beyond.

@DavidNix
Copy link
Contributor Author

DavidNix commented Jun 1, 2023

We could delete the cache on every restart, but I'm unsure how it will affect performance. Per the above, there will be a "slowdown".

I'd definitely recommend against that. You'd have to re-compile Wasm -> native for each contract after every start.

If you do it once per chain upgrade, that's safe enough. But at the end of the day that's a CosmWasm bug that will be fixed in 1.3 and beyond.

Thanks for the feedback @webmaster128. Can you point me to documentation or discussion that shows it will be fixed in 1.3 and beyond?

@webmaster128
Copy link

See CosmWasm/wasmvm#426 (comment)

@DavidNix
Copy link
Contributor Author

DavidNix commented Jun 2, 2023

Great! If we decide to move forward with this feature, it will be opt-in and only if the pod is crashlooping. We won't automatically blow away the cache on every restart.

@DavidNix
Copy link
Contributor Author

Rare edge case. Automation seems overkill, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants