Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horcrux should support bn254 key type. #225

Closed
dylanschultzie opened this issue Nov 22, 2023 · 3 comments · May be fixed by #236
Closed

Horcrux should support bn254 key type. #225

dylanschultzie opened this issue Nov 22, 2023 · 3 comments · May be fixed by #236
Assignees
@agouin

Comments

@dylanschultzie
Copy link

dylanschultzie commented Nov 22, 2023 •
edited by jonathanpberger
Loading

As SL
We want Union to be able to use Horcrux
Because we care about them

Union will require a new key type, bn254, rather than the tried-and-true ed25519 key. Here in their docs is the example:

https://docs.union.build/infrastructure/node_operators/getting-started#initialization

At the moment is appears you can manually change the key type to ed25519, but that appears to not be the recommended course of action.

With the importance of Union joining the cosmos, it seems worthwhile to support their preferred key scheme.
@nitronit
Copy link
Contributor

nitronit commented Dec 5, 2023

I think the work needed is slightly larger than just change the key type in Horcrux. You need to implement the curve.

With that said it is possible to implement the bn254 curve in Horcrux.

As a reference see:
https://github.com/IBM/TSS for a implementation of a threshold BLS using bn254 from Gnark-crypto
https://asecuritysite.com/bn/bn254
https://github.com/Consensys/gnark-crypto

@agouin agouin mentioned this issue Dec 18, 2023
Draft
@jonathanpberger jonathanpberger changed the title Add support for bn254 key type Horcrux should support bn254 key type. Mar 11, 2024
@danbryan
Copy link
Contributor

@agouin any update on this?

@jonathanpberger
Copy link

@agouin told @danbryan we don't need to track this story in this backlog. Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agouin agouin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

threshold bn254 key support strangelove-ventures/horcrux
5 participants
@jonathanpberger @danbryan @agouin @dylanschultzie @nitronit