Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create channel with specific version #155

Closed
Tracked by #1583
DavidNix opened this issue Jun 21, 2022 · 2 comments
Closed
Tracked by #1583

Create channel with specific version #155

DavidNix opened this issue Jun 21, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@DavidNix
Copy link
Contributor

From cian, ibc-go team:

a channel needs to be created with a specific version for it to be enabled, I don't know is that configurable with ibctest? This command is using hermes but I think it should probably work in a similar way with go relayer

hermes -c ./network/hermes/config.toml create channel test-1 connection-0 \
--port-a transfer \
--port-b transfer \
-v "{\"fee_version\":\"ics29-1\",\"app_version\":\"ics20-1\"}"

in our tests it would be nice to test behaviour when one side does not have it enabled etc.
looking at the code, I'm guessing this would be done through CreateChannelOptions.Version


Note: This may have relayer dependencies.

@DavidNix DavidNix added the enhancement New feature or request label Jun 21, 2022
@jtieri
Copy link
Member

jtieri commented Jun 21, 2022

The relayer commands for creating a new path should provide a --version flag so we should just need to add a field to the CreateChannelOptions struct like you mentioned.

@jtieri
Copy link
Member

jtieri commented Jun 29, 2022

Closed by #167

@jtieri jtieri closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants