Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have a pre-release check script #456

Open
mulkieran opened this issue Aug 30, 2023 · 2 comments
Open

We should have a pre-release check script #456

mulkieran opened this issue Aug 30, 2023 · 2 comments
Assignees

Comments

@mulkieran
Copy link
Member

mulkieran commented Aug 30, 2023

Makefile targets it should run:

  • audit
  • verify-dependency-bounds

It should also run cargo-package to verify packagability. It's possible that we should remove the cargo-package check from the release script, so long as we know it was run before the release. Is it practical to run a packaging test in CI? It seems like we do not run cargo-package anywhere in our GitHub Actions.

We should run both the Makefile targets in the package directory, if possible. As it stands, though, verify-dependency-bounds relies on having a second Makefile in the same directory, so that won't quite work.

@mulkieran mulkieran self-assigned this Aug 30, 2023
@mulkieran
Copy link
Member Author

In libcryptsetup-rs:

> cargo package
> cd target/package/libcryptsetup-rs-<version>
> make -f ../../../Makefile audit  // success
> SET_LOWER_BOUNDS=../../../../ci/dependency_management/set_lower_bounds make -f ../../../Makefile verify-dependency-bound
> cargo update --package=getrandom  --precise=0.2.0
> cargo update --package=is-terminal --precise=0.4.0
> SET_LOWER_BOUNDS=../../../../ci/dependency_management/set_lower_bounds make -f ../../../Makefile verify-dependency-bound // success
> make -f ../../../Makefile audit // success

@mulkieran
Copy link
Member Author

Note that cargo-package willl always fail if a path dependency has a version that is not yet released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant