Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lowest supported Rust toolchain to 1.58 #340

Closed
mulkieran opened this issue Aug 18, 2021 · 6 comments
Closed

Update lowest supported Rust toolchain to 1.58 #340

mulkieran opened this issue Aug 18, 2021 · 6 comments
Assignees

Comments

@mulkieran
Copy link
Member

mulkieran commented Aug 18, 2021

We'll plan to do this sometime in February and expect that it will 1.54 + 4 (+1) = 1.58 (1.59).

There are three places where value should be bumped to 1.58.1:

  • LOWEST SUPPORTED RUST TOOLCHAIN value in all GitHub workflows for Stratis repos
  • msrv value in .clippy.toml for all Stratis Rust repos
  • Values in non GitHub-workflows tests
@mulkieran mulkieran changed the title Update lowest supported Rust toolchain Update lowest supported Rust toolchain to 1.60 Aug 18, 2021
@mulkieran mulkieran changed the title Update lowest supported Rust toolchain to 1.60 Update lowest supported Rust toolchain to 1.59 Jan 19, 2022
@mulkieran
Copy link
Member Author

We can make use of the rust-version field and possibly drop the .clippy.toml file entirely (if clippy respects this field).

@mulkieran
Copy link
Member Author

Upstream rust issue for existing bug: rust-lang/rust#94505..

@mulkieran
Copy link
Member Author

mulkieran commented Mar 21, 2022

Wait until April for this. Upstream bug fix has been merged...

@mulkieran
Copy link
Member Author

Since it's actually 1.58 we can do it at any time.

@mulkieran
Copy link
Member Author

I want to postpone a little longer, so that we can do the packaged build testing that we do in ci easily.

@mulkieran mulkieran changed the title Update lowest supported Rust toolchain to 1.59 Update lowest supported Rust toolchain to 1.58 Apr 2, 2022
@mulkieran
Copy link
Member Author

Does our packaged build testing require this any more. I think not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants