Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate policy on lowest supported Rust version #713

Open
mulkieran opened this issue Jun 18, 2024 · 4 comments
Open

Re-evaluate policy on lowest supported Rust version #713

mulkieran opened this issue Jun 18, 2024 · 4 comments
Assignees

Comments

@mulkieran
Copy link
Member

Our current development (1.79) is almost a year ahead of our lowest supported (1.71) at this time. Do we have a reason to move up and are we able to move up?

@mulkieran mulkieran self-assigned this Jun 18, 2024
@github-project-automation github-project-automation bot moved this to To do in 2024June Jun 18, 2024
@mulkieran mulkieran removed this from 2024June Jul 3, 2024
@mulkieran mulkieran moved this to Todo in 2024July Jul 3, 2024
@mulkieran
Copy link
Member Author

mulkieran commented Jul 25, 2024

We have a lint-related reason now. It's pretty minor, though. We merged a clippy allow that would have been done nicer in a build script. Here's the PR: stratis-storage/devicemapper-rs#928 . Had we been running a newer version of Rust we would have handled that differently, by emitting instructions in build.rs: https://blog.rust-lang.org/2024/05/06/check-cfg.html.

@mulkieran mulkieran moved this from Todo to In Progress (long term) in 2024July Jul 25, 2024
@mulkieran mulkieran removed this from 2024July Aug 5, 2024
@mulkieran mulkieran moved this from Todo to In Progress (long term) in 2024August Aug 5, 2024
@mulkieran
Copy link
Member Author

mulkieran commented Aug 21, 2024

We have a more important reason that would require us to move up to 1.77.0, since bindgen 0.70.0 emits code for libcryptsetup which wasn't part of the standard library until 1.77.0. https://doc.rust-lang.org/std/mem/macro.offset_of.html# and https://github.com/stratis-storage/libcryptsetup-rs/actions/runs/10491531137/job/29060894678?pr=348 . No sign of any action in Fedora to update bindgen to new release, but could happen any time. Note that 1.77 is only a bit more than 4.5 months back.

@mulkieran
Copy link
Member Author

I have a feeling that we'll be happy to move up as soon as Fedora puts out a release of bindgen 0.70.0.

@mulkieran mulkieran moved this from In Progress (long term) to Pending in 2024September Sep 6, 2024
@mulkieran mulkieran removed this from 2024September Oct 7, 2024
@mulkieran mulkieran moved this from Todo to Pending in 2024October Oct 7, 2024
@mulkieran
Copy link
Member Author

We have another lint-related reason, reasons are still experimental in our lowest supported:

this Cargo does not support nightly features, but if you
switch to nightly channel you can pass
`-Zlints` to enable this feature.
 Downloading crates ...
  Downloaded termios v0.3.3
   Compiling stratisd v3.7.0 (/__w/stratisd/stratisd)
   Compiling termios v0.3.3
error[E0658]: lint reasons are experimental
  --> src/systemd/bindings.rs:11:5
   |
11 |     reason = "https://github.com/rust-lang/rust-bindgen/issues/2845"
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #54503 <https://github.com/rust-lang/rust/issues/54503> for more information

@mulkieran mulkieran removed this from 2024October Nov 4, 2024
@mulkieran mulkieran moved this from Todo to Pending in 2024November Nov 4, 2024
@mulkieran mulkieran removed this from 2024November Dec 3, 2024
@mulkieran mulkieran moved this to misc in tracking Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: misc
Development

No branches or pull requests

1 participant