Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Remove filter_input from plugin #14

Closed
straube opened this issue May 25, 2018 · 2 comments
Closed

Remove filter_input from plugin #14

straube opened this issue May 25, 2018 · 2 comments
Milestone

Comments

@straube
Copy link
Owner

straube commented May 25, 2018

From this discussion on WP.org support forum:

According to numerous reports filter_input(INPUT_SERVER…) on PHP with CGI/FastCGI might result in NULL being returned.
This happened to me recently and as such plugin’s constructor was assigning

$this->domain = $this->originalDomain;

which results in home page always redirecting to original domain.

Could you please fix it and use normal $_SERVER variables to determine domain instead of filter_input function?

Read comment from “anthony dot parsons at manx dot net” here for some details: http://php.net/manual/en/function.filter-input.php or google for ‘filter_input INPUT_SERVER returns null’ for bug confirmation.

@straube straube added this to the 0.8 milestone May 25, 2018
@QuietNoise
Copy link

Hi,

When you plan to implement it?

@straube
Copy link
Owner Author

straube commented Aug 2, 2018

Hi @QuietNoise,

Despite my effort to keep the plugin up to date and bug-free, I was really busy in the last months. I didn't start working on this issue. It sure requires some testing, but it doesn't seem a complex one at a first glance. If you could spare the project a couple hours, feel free to submit a PR. I really appreciate that. :)

@straube straube closed this as completed in 5bd39a2 Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants