Merge branch 'main' into claude/issue-11-20251026-2132

Author: strawgate

.github/workflows/claude-on-test-failure.yml

@@ -110,8 +110,7 @@ jobs:
 
           If you detect such a loop (e.g., you see multiple similar bot comments or your own previous analysis comments):
           1. **DO NOT** post another analysis comment
-          2. Instead, post a brief comment stating: "Loop detected: Multiple automated analysis comments found. Stopping to prevent further automated comments. Please review the existing analysis comments."
-          3. Exit immediately without further action
+          2. Exit immediately without further action
 
           # Problems Encountered
           If you encounter any problems during your analysis (e.g., unable to fetch logs, tools not working), document them clearly so the team knows what limitations you faced.
@@ -157,7 +156,6 @@ jobs:
             actions: read
 
           prompt: ${{ steps.analysis-prompt.outputs.PROMPT }}
-          track_progress: true
           claude_args: |
             --allowed-tools mcp__repository-summary,mcp__code-search,mcp__github-research,WebSearch,WebFetch,Bash(make:*,git:*)
             --mcp-config /tmp/mcp-config/mcp-servers.json

key-value/key-value-aio/src/key_value/aio/stores/base.py

@@ -14,6 +14,7 @@
 from key_value.shared.errors import StoreSetupError
 from key_value.shared.type_checking.bear_spray import bear_enforce
 from key_value.shared.utils.managed_entry import ManagedEntry
+from key_value.shared.utils.sanitization import PassthroughStrategy, SanitizationStrategy
 from key_value.shared.utils.serialization import BasicSerializationAdapter, SerializationAdapter
 from key_value.shared.utils.time_to_live import prepare_entry_timestamps
 from typing_extensions import Self, override
@@ -69,6 +70,8 @@ class BaseStore(AsyncKeyValueProtocol, ABC):
     _setup_collection_complete: defaultdict[str, bool]
 
     _serialization_adapter: SerializationAdapter
+    _key_sanitization_strategy: SanitizationStrategy
+    _collection_sanitization_strategy: SanitizationStrategy
 
     _seed: FROZEN_SEED_DATA_TYPE
 
@@ -78,13 +81,17 @@ def __init__(
         self,
         *,
         serialization_adapter: SerializationAdapter | None = None,
+        key_sanitization_strategy: SanitizationStrategy | None = None,
+        collection_sanitization_strategy: SanitizationStrategy | None = None,
         default_collection: str | None = None,
         seed: SEED_DATA_TYPE | None = None,
     ) -> None:
         """Initialize the managed key-value store.
 
         Args:
             serialization_adapter: The serialization adapter to use for the store.
+            key_sanitization_strategy: The sanitization strategy to use for keys.
+            collection_sanitization_strategy: The sanitization strategy to use for collections.
             default_collection: The default collection to use if no collection is provided.
                 Defaults to "default_collection".
             seed: Optional seed data to pre-populate the store. Format: {collection: {key: {field: value, ...}}}.
@@ -103,6 +110,9 @@ def __init__(
 
         self._serialization_adapter = serialization_adapter or BasicSerializationAdapter()
 
+        self._key_sanitization_strategy = key_sanitization_strategy or PassthroughStrategy()
+        self._collection_sanitization_strategy = collection_sanitization_strategy or PassthroughStrategy()
+
         if not hasattr(self, "_stable_api"):
             self._stable_api = False
 
@@ -117,6 +127,17 @@ async def _setup(self) -> None:
     async def _setup_collection(self, *, collection: str) -> None:
         """Initialize the collection (called once before first use of the collection)."""
 
+    def _sanitize_collection_and_key(self, collection: str, key: str) -> tuple[str, str]:
+        return self._sanitize_collection(collection=collection), self._sanitize_key(key=key)
+
+    def _sanitize_collection(self, collection: str) -> str:
+        self._collection_sanitization_strategy.validate(value=collection)
+        return self._collection_sanitization_strategy.sanitize(value=collection)
+
+    def _sanitize_key(self, key: str) -> str:
+        self._key_sanitization_strategy.validate(value=key)
+        return self._key_sanitization_strategy.sanitize(value=key)
+
     async def _seed_store(self) -> None:
         """Seed the store with the data from the seed."""
         for collection, items in self._seed.items():