Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Remove "streamdal" action #375

Open
dselans opened this issue Sep 29, 2024 · 3 comments
Open

Improvement: Remove "streamdal" action #375

dselans opened this issue Sep 29, 2024 · 3 comments
Labels
hacktoberfest Eligible for Hacktoberfest PRs help wanted Extra attention is needed

Comments

@dselans
Copy link
Contributor

dselans commented Sep 29, 2024

plumber contains a streamdal action that allows you to login, logout, search etc. on the old Streamdal (event-driven) SaaS platform.

Since streamdal moved into the open source data quality space, the plumber streamdal ... action no longer makes sense.

To remove this, you will need to update the protobuf definitions available here: batchcorp/schemas

^ This is because the plumber CLI is defined as protobuf (because the CLI options are highly coupled with the actions and params for the actions that plumber takes like plumber read rabbitmq ...).

This task is:

  • "Easy" if you have worked with protobuf and Go
  • "Medium" if you have worked with protobuf but not in Go
  • "Hard" if you have little to no experience with protobuf
@dselans dselans added help wanted Extra attention is needed hacktoberfest Eligible for Hacktoberfest PRs labels Sep 29, 2024
@arrlancore
Copy link

Hi @dselans I'm very interested in contributing to Plumber and this issue caught my eye! I have experience with Go and Protobuf and I'd love to give this a shot for Hacktoberfest, which starts tomorrow. Would it be alright if I take a closer look and reach out with any initial questions I have before diving into the implementation?

@dselans
Copy link
Contributor Author

dselans commented Sep 30, 2024

Yeah absolutely, go for it!

@arrlancore
Copy link

arrlancore commented Oct 1, 2024

Hi @dselans, I've created a draft PR. Could you please review it to ensure it fully addresses the requirement to remove Streamdal?

I'm also having trouble testing it. I've tried copying the newly generated plumber-schemas to the plumber > vendor > [path to] > plumber-schemas > build > go > protos directory, but I'm encountering numerous undefined Streamdal errors. This is likely due to the ongoing use of Streamdal in several plumber code areas. Is this expected behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Eligible for Hacktoberfest PRs help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants