Persistent error report when a subscripted channel is banned

[luett1]

Description

When you are subscripted to a banned channel, the Streamlink Twitch GUI cant handle the error coming back from the Twitch API when switching to the tab "My" - "Subscriptions".

Expected / Actual behavior

When you are subscripted to a banned channel and you go to the tab "Subscriptions" under "My", the GUI shows you an error.

However, as you can see, it doesnt actually goes to the tab "Subscriptions". So the tab currently selected (in this case "Live Streams") is stuck on that error message. Neither clicking on the current tab (in this case "Live Streams") or pressing F5 will show the actual content, instead after a short loading screen will show the error again.
To actually view the tab selected before pressing "Subscriptions" again you have to change to a different tab and then switch back.
This will happen regardless of the tab you start with before pressing "Subscriptions".

Since I am only subscribed to this one channel, I dont know how the GUI would handle this issue when subscripted to more than one channel, but I would assume its the same, making it impossible to see your subscriptions if one gets banned.

Reproduction steps

1. Go to any tab (except Subscriptions)
2. click onto "Subscriptions" while at least one of your subscripted channels is banned
3. The tab selected in Step 1 is now stuck on this error.

Environment details (operating system, etc.)

Windows 10
Streamlink Twitch GUI v1.0.1
Streamlink v0.2.0

[bastimeyer]

Can you please validate that this fix is working for you? The subscriptions API is private (undocumented) and I don't have any tests for this unfortunately.

The only way of fixing this bug was removing the whole subscription record of the banned channel. Banned channels can't be accessed via the API, so no informations are available. The banned channel will not appear in the subscriptions list.

The route error states are a bit messy and maybe a bit confusing. You didn't transition to the user.subscriptions route due to the adapter error, that's why the main menu indicator is showing the old route.

You need to build the application on your own to test and validate this. Please see the build guide. Thanks!

git clone https://github.com/streamlink/streamlink-twitch-gui.git
cd streamlink-twitch-gui
git checkout origin/banned-channel-sub-fix
npm install -g grunt-cli bower
npm install
grunt build

[luett1]

ok I will try your fix tomorrow. I never build an application before.

[luett1]

Sorry I cant get it to work.
I installed Git and Node.js (v.7.2.1) with npm and after copying all your code in cmd.exe as an administrator, I always get stuck on your last command with the following just getting printed in the command windows over and over again.
Using v0.19.0 (sdk)
Create cache folder in C:\Windows\System32\streamlink-twitch-gui\build\cache\0.19.0-sdk
Using cache for: win64
Launching App
App exited with code 0

Here are screenshots of my command prompt:

I believe it has to do with the minimatch error you can see on pic 2, but as you can see on pic 1 i apparently have minimatch v3.0.3 installed.
I tried all the fixes which are written here, but the errors are still there.

I don't know what to do, as written above I have no experience or knowledge in building applications.

Im going to try and reinstall everything, but I fear this wont do anything.

EDIT: between pic 2 and pic 3 there are a few lines of code missing, since they go trough so fast I cant screenshot them, but they appear to only show install code and no additional errors.

[bastimeyer]

Don't worry...

getting printed in the command windows over and over again
Launching App
App exited with code 0

You have to close the already running Streamlink Twitch GUI process.
You can't run the same NW.js app (using the same app id) twice.

I believe it has to do with the minimatch error

It's completely unrelated and just a warning generated by the app's dependencies. Please don't link to these other issue threads, as there will be a reference created to this thread here, which is unnecessary spam :)

Btw, you don't have to post screenshots if they only contain text. Pictures say more than thousand words, but pictures containing only text do not.

[luett1]

EDIT: didnt read/saw your commend before writing this comment. I will try again and write another reply.

[luett1]

It does seem to work now.
When clicking on the tab "Subscriptions", it shows

this,

so it seems to work now. It doesnt get stuck on an error and it apparently also goes to the "Subscription" tab.

Sorry about the linking and the pictures, didnt know that it would get tagged in the other thread. Is removing the link helping or is the damage already done?

btw, I feel really stupid for not closing the GUI while trying this :/

[bastimeyer]

It's fine, no damage is done.
Thanks for taking the time testing it. 👍

[Ennapocryph]

This bug seems to have popped up again, although with a different error message:

Expected: 'twitch-user:lcpl_liru' to be present in the adapter provided payload, but it was not found.

Streamlink Twitch GUI version 1.8.1

[bastimeyer]

When channels are banned, (v5) API responses don't include any data or include other unexpected stuff. This is the issue here and STG needs to detect and modify these special responses, so that they can be properly consumed by the data store.

Please open a new issue and add a description of what you were doing when this error occured.