Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Search if first word is a number #610

Closed
mystomex opened this issue Dec 7, 2018 · 1 comment
Closed

Cannot Search if first word is a number #610

mystomex opened this issue Dec 7, 2018 · 1 comment
Labels

Comments

@mystomex
Copy link

mystomex commented Dec 7, 2018

Its a simple bug report Im not gonna fill out all that info. if you dont want to hear it then oh well

Win 10, streamlink twitch gui 1.6.0

Cannot search anything with a number then space as the first 2 characters such as the game 7 Days To Die
just try searching the game and see how nothign happens when you exclude the number it works.

@bastimeyer
Copy link
Member

if you dont want to hear it then oh well

The issue templates are considered optional and are there to make people think before they submit an issue, so that the time spent by the dev(s) on the issue tracker can be minimized. For those simple reports like this one it's absolutely fine if you just describe what's not working correctly, just like you did, so don't worry.


The input field of the search bar component requires you to enter at least 3 non-whitespace characters at the beginning of your query. This has nothing to do with a leading number. See here:
https://github.com/streamlink/streamlink-twitch-gui/blob/v1.6.0/src/app/ui/components/search-bar/component.js#L38

This restriction was added with channel/user names in mind, but doesn't work well when searching for certain games or stream titles. The entire search bar component is in desperate need of a complete rewrite, but I can't do it yet, because I still need to finish some other stuff first which a new implementation would depend on. For now, I'll simply change or remove the regexp. That should fix this issue at least. I'll do this tomorrow when I get the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants