Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation window pops up after typing a number in the settings menu #647

Closed
2 tasks done
nikuolive opened this issue Jun 19, 2019 · 1 comment
Closed
2 tasks done
Labels

Comments

@nikuolive
Copy link

Bug report

  • I understand the difference between Streamlink and Streamlink Twitch GUI.
  • This is a bug report and I have read the contribution guidelines.

Environment details

Operating system and version:
Arch Linux x86_64

Streamlink Twitch GUI version:
1.7.1

Streamlink version:
1.1.1

Configuration details:
Fresh install from AUR using yay

Description

Typing a number in one of the input area in the settings menu pops out a confirmation window even I'm not done typing. Does not happen when I'm typing any characters other than numbers.

Expected behavior

Confirmation window only pops up if I when to any other menu before saving / discarding any changes in the settings menu

Reproduction steps

  1. Go to the settings menu
  2. Select any input area in the settings menu
  3. Type a number in the input area
  4. Confirmation window should pops up

Additional comments, screenshots, etc.

Peek 2019-06-19 22-32

Confirmation window did not pops up if you are typing a character.

Peek 2019-06-19 22-33

Pops up if you type a number

@bastimeyer
Copy link
Member

Thanks for the bug report!

This issue here was related to the HotkeyService and the hotkeys 0-9 for navigating the menus. Something must have changed recently and this went through unnoticed.

It's fixed on the master branch now (you can use the -git AUR package if you want). I will probably have to publish a patch release because of this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants