Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

ISSUE-16652: Build the docker image without dockerfile-maven-plugin #4565

Open
sijie opened this issue Jul 18, 2022 · 0 comments
Open

ISSUE-16652: Build the docker image without dockerfile-maven-plugin #4565

sijie opened this issue Jul 18, 2022 · 0 comments

Comments

@sijie
Copy link
Member

sijie commented Jul 18, 2022

Original Issue: apache#16652


As described in apache#16642, dockerfile-maven-plugin doesn't support Apple M1 and the project itself is end-of-life.

For supporting developers using Apple M1 clip, we can migrate the building logic to other plugin. Here's some candidates:

  • docker-maven-plugin is provided by fabric8io and actively maintained. However, the plugin logic is quite different from dockerfile-maven-plugin as the former may be over fruitful.
  • maven-exec-plugin. dockerfile-maven-plugin is effectively a thin wrapper of docker commands. We may directly run those commands with maven-exec-plugin.
  • A makefile. Apache SkyWalking uses a Makefile to hold logics about building docker image. It should be in the same direction with maven-exec-plugin but switches build system switch to Makefile.

cc @lhotari what do you think? At least I'd like to know the effectively executed docker commands so that I can run from command line interface and build those images manually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant