[feature] Set/get topic schema compatibility strategy #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce set/get
Update README
github-actions
bot
added
doc
nodece
reviewed
Jul 19, 2022
| // SetSchemaCompatibilityStrategy sets the strategy used to check the a new schema provided | ||
| // by a producer is compatible with the current schema before it is installed | ||
| SetSchemaCompatibilityStrategy(topic utils.TopicName, | ||
| strategy utils.SchemaCompatibilityStrategy) error |
There was a problem hiding this comment.
You need to add a new structure SchemaCompatibilityStrategyV2, link to https://github.com/apache/pulsar/blob/master/pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/SchemaCompatibilityStrategy.java#L24
There was a problem hiding this comment.
Thanks, could you explain a little more? Are the values in each expected to differ? Or is a separate strategy required for another reason?
There was a problem hiding this comment.
There are different values here.
nodece
suggested changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #783
Motivation
pulsarctlcannot be used to set topic level schema compatibility strategies.Modifications
Added get/set commands for topic.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-requiredno-need-docdocpulsar-admin.