Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect _errorCounts value #100

Open
stevendesu opened this issue Sep 10, 2019 · 1 comment
Open

Incorrect _errorCounts value #100

stevendesu opened this issue Sep 10, 2019 · 1 comment

Comments

@stevendesu
Copy link

Currently when HLS.js freezes it fires several non-fatal "bufferStalled" and "bufferNudgeOnStall" errors before firing a single fatal "bufferStalled" error. All of these errors count as "media" errors, and so _errorCount["media"] is set to 6 or 7 before _handleMediaError() gets called (by the fatal one) - meaning we never attempt _hls.recoverMediaError() or _hls.swapAudioCodec()

Should be a trivial fix of moving the increment/set error count step to within the if (data.fatal) block
@tri170391
Copy link
Contributor

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tri170391 @stevendesu