Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand quest for building characteristics to all buildings #109

Closed
gsurrel opened this issue Apr 6, 2017 · 3 comments
Closed

Expand quest for building characteristics to all buildings #109

gsurrel opened this issue Apr 6, 2017 · 3 comments

Comments

@gsurrel
Copy link

gsurrel commented Apr 6, 2017

I feel like the quest asking for building height only consider the "building=yes". It would be nice to expand to "building=*".

@westnordost
Copy link
Member

They specifically do not consider building=yes. They only consider
house|residential|apartments|detached|terrace|farm|hotel|dormitory|houseboat|school|civic|college|university|public|hospital|kindergarten|transportation|train_station|retail|commercial|warehouse|industrial|manufacture

And this is intended.

It is not reasonable to ask for an "unspecified building" how many levels it has, because perhaps it does not have levels. How many levels does this church have, how many levels these garages etc?
I want the least amount of "false positive" quests in the app as possible.

However, a "what type of building" quest is planned, that replaces the building=yes bulidings with more specific buildings. From there on, the building level quest can be asked.

@gsurrel
Copy link
Author

gsurrel commented Apr 6, 2017

Fair explanation :)

Therefore, I do not understand why the buildings in EPFL are not suggested for the number for stories (geo:46.519276,6.5639663?z=17
http://osmand.net/go?lat=46.519276&lon=6.5639663&z=17)

I also have the same behavior near this train station: geo:46.53781,6.5832553?z=19
http://osmand.net/go?lat=46.53781&lon=6.5832553&z=19

I know there are many notes around but even when zooming to the maximum on the specific buildings, they do not show up.

No matter what, thanks a lot for the app, I love it :)

@westnordost
Copy link
Member

They are not considered because they are tagged with building=yes+amenity=university. This is wrong, it should be building=university.
As for the train station, the quest is not shown because the building levels were already added by use Xinfe 8 hours ago (with StreetComplete).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants