Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark - bright theme - automatic switching did not work - minor bug #1400

Closed
ghost opened this issue May 16, 2019 · 5 comments
Closed

Dark - bright theme - automatic switching did not work - minor bug #1400

ghost opened this issue May 16, 2019 · 5 comments
Labels
feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@ghost
Copy link

ghost commented May 16, 2019

While having my other bug, I found a new, minor one.

The automatic switching of bright-dark theme did not work. It worked only after manually switching to dark, then bright, then auto again (switching to bright might be skipped, but thats what I did).

I guess, that the standard setting is bright, though it shows auto in the settings.

@westnordost
Copy link
Member

In which cases does it not work? Do you expect to use the app and then at sundown, it switches to dark? Or does not not work at all, even if you end the app and start it new?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label May 23, 2019
@matkoniecz
Copy link
Member

In my experience app attempts to

use the app and then at sundown, it switches to dark

but sometimes it breaks. For example styling changing partially, resulting in black text on very dark background. So far I made no attempts to reproduce it as change seems to happen depending on time (and I am not using dark style at all, so I never encountered it in my own use).

Restarting app fixed it in two cases when I encountered it.

@westnordost
Copy link
Member

I cannot reproduce this.

@gmischler
Copy link

A few days ago, I have seen the "black text on dark background" effect as well.
I think that happened when I had selected "dark" manually during the day.
The "auto" setting seems to do the right thing day and night.
When I select "light" at night, everything looks as expected as well.
Apparently there is a specific combination of time and settings (and/or maybe sequence of settings changes) that triggers the issue.

@westnordost
Copy link
Member

The "black text on dark background bug" (and the opposite) has been fixed some versions ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

3 participants