Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for crossings when a path meets but does not cross a road #3245

Closed
arrival-spring opened this issue Sep 2, 2021 · 3 comments
Closed
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@arrival-spring
Copy link
Contributor

With the changes introduced from #3205, would it be suitable to also ask for case '4' (second row on the left) of here:
#398 (comment)
? i.e. when a path meets a road but does not cross it

When a path meets a road, there is often a crossing. Most often in urban environments and where there is a pavement (sidewalk) on the other side. Not sure f it's easy to check for the latter though.

@westnordost
Copy link
Member

So, this case

image

Hmm to be honest, the implementation is quite complex, I don't want to change anything here for now. I am not sure if it can be cleanly separated from this case:

image

@arrival-spring
Copy link
Contributor Author

Yes, that's the case I meant.

I wonder how common that other case is? But I suppose that also in that case in an urban situation with pavement on the other side, there could well be a crossing.

This new quest is catching lots more crossings as is, which is great, so fair enough not wanting to change it much now

@westnordost
Copy link
Member

westnordost commented Sep 6, 2021

It would enormously simplify the code though if it is not checked for crossing the road anymore. On the other hand, I think some/many situations exist where there is a (foot and cycleway) path that branches of a street and the kerb is lowered at that position.
But it is not lowered at this position because there is a crossing, but it is lowered so that cyclists and service vehicles (gardeners etc.) can enter this path from the street.

So in cases like these, the app would still add highway=crossing to the node, which might be wrong (but is the whole point of the quest), e.g. on the other side of the road, there could be e.g. a colon of parking cars, so it's really not possible to cross the road at that point.

@westnordost westnordost added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

2 participants