-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
red for missing data and black for =no
is confusing, at least to me
#4128
Comments
Pink would lead to confusion, at least in the dark theme. Railway tracks are already pink coloured. |
Ugly pink would work fine for me (Vespucci also uses that for missing data there and it's quite clear and understandable). Dark theme does indeed use pink for railway, perhaps that could be changed instead? I never liked that bright pink for railway (and bright cyan for bigger roads) anyway - it's supposed to be dark theme so I can comfortably use it in low-light conditions, and not have eye-piercing spikes like that. Couldn't they just be tones of subdued dark greyish-violet like the rest of roads, or something? |
See also streetcomplete/streetcomplete-mapstyle#107 (Maybe railways in dark mode are too prominent) I actually started doing this, but want to solve streetcomplete/streetcomplete-mapstyle#130 first (Consider officially archiving other branches?) |
Would it help if sidewalk=yes was blue, not green? The reason for choosing red in all overlays as "is missing" is because red is the most disruptive color that is also associated with errors, prohibitions, destructive actions etc. E.g. you want your unit tests to be green, not red. A pink does not really have an association with errors and mistakes. |
You cannot have green and red as the only thing differentiating between values if you want to be accessible to colourblind users, so yes blue would be better. |
This is how the current color palettes look like with different color deficiencies:
|
private val LitStatus?.color get() = when (this) { | |
LitStatus.YES, | |
LitStatus.UNSUPPORTED -> "#ccff00" | |
LitStatus.NIGHT_AND_DAY -> "#33ff00" | |
LitStatus.AUTOMATIC -> "#00aaff" | |
LitStatus.NO -> "#555555" | |
null -> Color.UNSPECIFIED | |
} |
See https://davidmathlogic.com/colorblind/#%23CCFF00-%2333FF00-%2300AAFF-%23555555-%23FF0000
SidewalkOverlay
StreetComplete/app/src/main/java/de/westnordost/streetcomplete/overlays/sidewalk/SidewalkOverlay.kt
Lines 64 to 69 in 4d063fa
private val Sidewalk?.color get() = when (this) { | |
Sidewalk.YES -> "#33cc00" | |
Sidewalk.NO -> "#555555" | |
Sidewalk.SEPARATE -> Color.INVISIBLE | |
Sidewalk.INVALID, null -> Color.UNSPECIFIED | |
} |
See https://davidmathlogic.com/colorblind/#%2333CC00-%23555555-%23FF0000
Maybe not that, but I, and clearly others in this thread use it as a "highlighter" colour. E.g. I'll flag a cell in a spreadsheet like that where the value is a bit of an estimate or
entirely. For both lit and sidewalk, they are nominally a tri-state (is or isn't lit, sidewalk present or not) and then data is missing. With possibly some further refining of some values (e.g. lit/night and day/automatic are all essentially "true", likewise "yes" and "separate" are broadly the same for sidewalk). Which I'd have thought, and indeed seem to be, somewhat related. |
Thank you for the link, @FloEdelmann |
Maybe? Hard to guess how I would react initially, without being aware what is being shown. But it would break green-red dynamic at least. |
I keep expecting that red is for
no
and black is for missing data.Maybe some ugly garish pink for missing data would be better?
The text was updated successfully, but these errors were encountered: