Sometimes quest markers are not shown, but only their dot

[Strubbl]

How to Reproduce
I experienced sometimes that quest icons are not shown, please see the screenshot below. You can only see the dot, that there is a quest, but not the quest icon. I need to play with the zoom and rotate functions in order to get the quest icon and to be able to solve the quest.

The example from the screenshot is the area https://www.openstreetmap.org/node/2755699329. It was taken when i zoomed to the maximum zoom level.

Expected Behavior
Display the quest marker when there is no other quest around.

Versions affected
48.0-beta1

[Helium314]

I remember there was some similar issue previously, where some labels(?) were causing quests to be hidden, but that was already solved...
Is the quest shown if you disable the overlay?

[Strubbl]

Unfortunately this quest from the screenshot is solved already. If i see a similar issue, i will try switching off the overlay.

[Helium314]

Probably no need, I just found a quest being hidden by a label (name of the path).

[westnordost]

Hm, I've come to the conclusion that this is either a tangram-es issue or I didn't understand something. In either case, this cannot be fixed (by me).

1. I can confirm that indeed the pin is hidden by the label of a road and the housenumber label. Tested with the pin for the building type quest on this road. Road labels have a priority of 25. Text with a lower priority value are drawn first and occlude others.

2. The priority of the streetcomplete-pins layer (the layer in which the quest pins are shown) however is smaller than 1. So it should always be in front of other labels. Even if I hardcode a priority of 0.5, still the road label occludes the quest pin. It also occludes the pin if the pins layer has a higher priority than 25.

3. The blend_order of a drawing style defines what is drawn on top. the blend_order of the pin-icons style which is used to draw the streetcomplete_pins layer as defined in streetcomplete.yaml is 2. Even if I increase that to an absurdly high number, the road label still occludes the pin.

4. The order property is documented to have no effect on styles drawn as an overlay (road labels, quest pins), however it is still defined for good measure. But in any case, I can confirm that it has no effect, just like priority and blend_order seem to have no effect either.

So, it seems nothing can be done to make tangram-es not obscure the pin for the text label. I also noticed that nothing changed in this code since 2021 and nothing really relevant changed since 2016. So, this issue can't be new.

[westnordost]

But in any case, maybe someone else would like to look at this issue. I propose to do a bisect (i.e. check if older versions had the same issue / in which version it was introduce).

[hamishmb]

I'll be happy to do a bisect at some point - I was already considering setting up Android Studio for confirming/regression testing bugs soon anyway.

[westnordost]

No need for that, you could just download the APKs from the releases page from here on GitHub. (It's also faster, because compilation takes so long)

[mcliquid]

I had this issue today. Zooming in and out sometimes helps but not everytime.

[hamishmb]

I'll just test them with AVDs then, once I've got those set up.

[Helium314]

The solution appears to be the same as for the flickering water labels: streetcomplete/streetcomplete-mapstyle#136 (comment)
Including the part where using 0 + feature.scalerank behaves differently than feature.scalerank.

[westnordost]

ah right, thanks