-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAT identification number #5933
Comments
I went through some small sample in https://commons.wikimedia.org/wiki/Category:Shops_in_the_Czech_Republic ( say https://commons.wikimedia.org/wiki/File:Praha_Haje_Arkalycka_Kik.jpg https://commons.wikimedia.org/wiki/File:2022-07-13_Praha,_Galerie_Butovice,_diskontn%C3%AD_prodejna_Action_02.jpg https://commons.wikimedia.org/wiki/File:Alza.cz,_Brno_(2).jpg ) but either it was not there or I missed it. Where it typically is?
I would assume that it would be Czech-specific, at least in Poland I have never seen it. |
I would guess it's too small to see on these photos. Maybe left of the credit cards in https://commons.wikimedia.org/wiki/File:2022-07-13_Praha,_Galerie_Butovice,_diskontn%C3%AD_prodejna_Action_02.jpg or on the rightmost part of the entrance door in https://commons.wikimedia.org/wiki/File:Alza.cz,_Brno_(2).jpg
Judging by taginfo, it's also common in Germany and Hungary (and mostly a European thing)
What is the useful purpose? Are there any consumers for this tag? |
It's pretty common to use a large enough font to see it from streetview etc., but it's not common on chain stores. I can take some pictures when I go for a walk.
Talking OSM not right now, but can be useful to verify shop owners etc. in the future. I want to use it and I would be okay with implementing this quest myself. |
It is relatively common in Croatia (see e.g. https://user-images.githubusercontent.com/156656/220413690-951d7fd4-c41d-40f6-a7e4-b193a768c421.jpg), but the displayed While I do add the tag myself sometimes, I must admit that big issue is satisfying StreetComplete's "🤷 Useful purpose". I.e. are there any data consumers actually using it? (My use case is that it is linked to Croatian registry of Companies, so it can be verified when it goes out of business, or changes address, etc.)
Good to know (being willing to write the quest might tip the balance sometimes!), but note that in general for quest to be accepted in StreetComplete it really should appeal to sizeable percentage of users (even if the quest is disabled by default, there is non-zero cost to both the maintainers and users that is incurred by adding a quest) Footnotes
|
Utterly pointless for the UK. UK VAT numbers only appear on receipts, invoices and other financial paperwork. They cannot be surveyed. So I'd implemented disable it for the UK. |
Same in DE |
As others have mentioned, it's not clear what is the useful purpose to record this information in OSM. Currently, there are no users and it remains unknown what might be the users.
Will be very country-specific. I.e. in some/most? countries, it doesn't make sense to ask because shops don't need to state this info publicly. In those countries where they have to state it, it's still expected to be somewhat hidden (e.g. some abbreviation used for VAT) and/or provided each in a different location. So, it may be difficult and cumbersome to note down that number.
Others have noted that apart from the information whether this quest should be asked at all for a country, the number as displayed on the sign might need to be prepended by some identifier to fit Is it worth the effort to implement? And then, is it worth...
...asking mappers to note down this number for every shop they find (in a country where this quest is enabled)? I don't think so, see also "useful purpose". So, all in all, it seems clear to me that it doesn't meed the quest guidelines. Some points of these guidelines are softened for SCEE, if you want to implement this yourself (and hence "🕓 Effort vs impact" doesn't count, because it is you who makes the effort), maybe this could fit for SCEE instead. Better consult their quest guidelines before posting a PR there, though. |
The PR was actually already created before you closed the issue |
Sorry for not responding to your comment earlier, 1. it was pretty easy to implementcountry specific validation: return when (countryPrefix) {
"CZ" -> vatin.length in 2 + 8..2 + 10 && vatin.substring(2).all { it.isDigit() }
"SK" -> vatin.length == 2 + 10 && vatin.substring(2).all { it.isDigit() }
else -> vatin.length >= 2 + 2 // Romania
} 2. won't be enabled by defaultI'd never want to make this enabled by default, as you said surveyor's time is valuable |
Cool, looks sleek. I am happy that you created a PR over at SCEE |
General
Affected tag(s) to be modified/added: ref:vatin
Question asked: What VAT identification number does this place have?
Checklist
Checklist for quest suggestions (see guidelines):
Ideas for implementation
Element selection:
Metadata needed:
Proposed UI:
The text was updated successfully, but these errors were encountered: