Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAT identification number #5933

Closed
5 tasks done
vfosnar opened this issue Sep 28, 2024 · 11 comments
Closed
5 tasks done

VAT identification number #5933

vfosnar opened this issue Sep 28, 2024 · 11 comments

Comments

@vfosnar
Copy link

vfosnar commented Sep 28, 2024

General

Affected tag(s) to be modified/added: ref:vatin
Question asked: What VAT identification number does this place have?

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam) - it's pretty common to have them signed on the outside here in Czech Republic, may be different in other countries
  • 🕓 Applies to a reasonable number of map data (Worth the effort)

Ideas for implementation

Element selection:

Metadata needed:

Proposed UI:

@matkoniecz
Copy link
Member

I went through some small sample in https://commons.wikimedia.org/wiki/Category:Shops_in_the_Czech_Republic ( say https://commons.wikimedia.org/wiki/File:Praha_Haje_Arkalycka_Kik.jpg https://commons.wikimedia.org/wiki/File:2022-07-13_Praha,_Galerie_Butovice,_diskontn%C3%AD_prodejna_Action_02.jpg https://commons.wikimedia.org/wiki/File:Alza.cz,_Brno_(2).jpg ) but either it was not there or I missed it.

Where it typically is?

may be different in other countries

I would assume that it would be Czech-specific, at least in Poland I have never seen it.

@Helium314
Copy link
Collaborator

but either it was not there or I missed it

I would guess it's too small to see on these photos. Maybe left of the credit cards in https://commons.wikimedia.org/wiki/File:2022-07-13_Praha,_Galerie_Butovice,_diskontn%C3%AD_prodejna_Action_02.jpg or on the rightmost part of the entrance door in https://commons.wikimedia.org/wiki/File:Alza.cz,_Brno_(2).jpg

I would assume that it would be Czech-specific

Judging by taginfo, it's also common in Germany and Hungary (and mostly a European thing)

to be added tag is established and has a useful purpose

What is the useful purpose? Are there any consumers for this tag?

@vfosnar
Copy link
Author

vfosnar commented Sep 28, 2024

I would guess it's too small to see on these photos.

It's pretty common to use a large enough font to see it from streetview etc., but it's not common on chain stores. I can take some pictures when I go for a walk.

What is the useful purpose? Are there any consumers for this tag?

Talking OSM not right now, but can be useful to verify shop owners etc. in the future. I want to use it and I would be okay with implementing this quest myself.

@mnalis
Copy link
Member

mnalis commented Sep 28, 2024

It is relatively common in Croatia (see e.g. https://user-images.githubusercontent.com/156656/220413690-951d7fd4-c41d-40f6-a7e4-b193a768c421.jpg), but the displayed OIB is not really in ref:vatin format, so it would be failing "👨‍💻 Users are no experts" unless some per-country app logic was added (for Croatia, you need to add leading HR and any missing leading zeroes to pad the number to 11 digits) - and adding such logic for all countries would likely be failing "🕓 Effort vs impact". 1

While I do add the tag myself sometimes, I must admit that big issue is satisfying StreetComplete's "🤷 Useful purpose". I.e. are there any data consumers actually using it?

(My use case is that it is linked to Croatian registry of Companies, so it can be verified when it goes out of business, or changes address, etc.)

I want to use it and I would be okay with implementing this quest myself.

Good to know (being willing to write the quest might tip the balance sometimes!), but note that in general for quest to be accepted in StreetComplete it really should appeal to sizeable percentage of users (even if the quest is disabled by default, there is non-zero cost to both the maintainers and users that is incurred by adding a quest)


Footnotes

  1. It however might fit SCEE (StreetComplete "Expert edition" fork) which has more relaxed quest inclusion rules (e.g. requiring domain expertise from the user is fine, and having quests useful for smaller groups only is also more acceptable). That being said, if you're using SCEE and you're comfortable with fixing the VAT ID format yourself, you might as well just use raw tag editor (in its Expert Mode) to add ref:vatin manually (which is what I do currently)

    One advantage that quest over raw tag editor might have, would be if it implemented those formatting issues automatically, and checked the number validity (for Croatia, using ISO 7064, module 11.10), but that puts effort through the roof if more than one country is to be supported.

@davidpnewton
Copy link

Utterly pointless for the UK. UK VAT numbers only appear on receipts, invoices and other financial paperwork. They cannot be surveyed. So I'd implemented disable it for the UK.

@HolgerJeromin
Copy link
Contributor

Utterly pointless for the UK. UK VAT numbers only appear on receipts, invoices and other financial paperwork.

Same in DE

@vfosnar
Copy link
Author

vfosnar commented Sep 29, 2024

20240929_111104_lmc_8 4

This is an entrance to a local pub, you can see both DIČ (VAT) and IČO (CZ & SK company identifier)

But sometimes the visibility us much worse, in the next photo it's at the bottom of the opening hours (otevírací doba) paper

20240929_111036_lmc_8 4

@westnordost
Copy link
Member

westnordost commented Sep 29, 2024

🚧 Established tags / 🤷 Useful purpose

As others have mentioned, it's not clear what is the useful purpose to record this information in OSM. Currently, there are no users and it remains unknown what might be the users.

👨‍💻 Users are no experts / 🐿️ Easy answer

Will be very country-specific. I.e. in some/most? countries, it doesn't make sense to ask because shops don't need to state this info publicly. In those countries where they have to state it, it's still expected to be somewhat hidden (e.g. some abbreviation used for VAT) and/or provided each in a different location. So, it may be difficult and cumbersome to note down that number.

🕓 Effort vs impact

Others have noted that apart from the information whether this quest should be asked at all for a country, the number as displayed on the sign might need to be prepended by some identifier to fit ref:vatin, which adds to the overall complexity to implement this.
Also note, that quests for shops are kind of expensive to implement because e.g. here in this case, a lot more places would be expected to have a ref:vatin than just anything with shop=* but also some stuff under amenity, under craft, under office and more. So, to create a filter for that and maintain it will be quite a bit of work.

Is it worth the effort to implement? And then, is it worth...

💵 Valuable Surveyors

...asking mappers to note down this number for every shop they find (in a country where this quest is enabled)? I don't think so, see also "useful purpose".

So, all in all, it seems clear to me that it doesn't meed the quest guidelines. Some points of these guidelines are softened for SCEE, if you want to implement this yourself (and hence "🕓 Effort vs impact" doesn't count, because it is you who makes the effort), maybe this could fit for SCEE instead. Better consult their quest guidelines before posting a PR there, though.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2024
@Helium314
Copy link
Collaborator

Better consult their quest guidelines before posting a PR there, though.

The PR was actually already created before you closed the issue

@vfosnar
Copy link
Author

vfosnar commented Sep 29, 2024

Sorry for not responding to your comment earlier,

1. it was pretty easy to implement

country specific validation:

return when (countryPrefix) {
    "CZ" -> vatin.length in 2 + 8..2 + 10 && vatin.substring(2).all { it.isDigit() }
    "SK" -> vatin.length == 2 + 10 && vatin.substring(2).all { it.isDigit() }
    else -> vatin.length >= 2 + 2 // Romania
}

2. won't be enabled by default

I'd never want to make this enabled by default, as you said surveyor's time is valuable

@westnordost
Copy link
Member

Cool, looks sleek. I am happy that you created a PR over at SCEE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants