Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things Overlay: Note for an object "blocks" thing. #6089

Closed
kmpoppe opened this issue Jan 7, 2025 · 3 comments
Closed

Things Overlay: Note for an object "blocks" thing. #6089

kmpoppe opened this issue Jan 7, 2025 · 3 comments

Comments

@kmpoppe
Copy link
Collaborator

kmpoppe commented Jan 7, 2025

This is the situation:

This amenity=vending_machine and This note are in the exact same spot. The note was not created by SC for this exact object but from the website.

It is currently not possible to select the vending machine, every time you tap the spot, the Note opens (and yes, this has been the case even before I added something to the note using SC):

Same goes for this node and this note which was created by SC.

No matter how far I try to zoom in, there's no way to tap the Thing rather than the Note.

I'm almost certainly lacking the skill the provide a workable solution, but wouldn't it be sweet if more than one distinct object (Quest or Overlay object) are in the area there user tapped, a box would appear that lets you choose which object you want to highlight?

Something like this:

More than one object tapped. Which one do you want to activate?
Bicycle Parking (node/26873320916)
Map Note (note/4567983)
@kmpoppe kmpoppe added the bug label Jan 7, 2025
@mnalis
Copy link
Member

mnalis commented Jan 7, 2025

No matter how far I try to zoom in, there's no way to tap the Thing rather than the Note.

To clarify, in this particular case at least they are visually get quite separated when zoomed in all the way:

small_Screenshot_20250107_125500_StreetComplete

But clicking on the the vending machine icon still opens up the note (which is likely quite confusing to the user). So perhaps at least this-note-belongs-to-an-object sensitivity should be made the same as Maplibre max zoom used? I.e. do not trigger a note opening if it is possible that the user has clicked on separate (non-note) icon.

I'm almost certainly lacking the skill the provide a workable solution, but wouldn't it be sweet if more than one distinct object (Quest or Overlay object) are in the area there user tapped, a box would appear that lets you choose which object you want to highlight?

That would be great, I agree. I do however think there were similar suggestions in the past (esp. in times of Tangram-ES before Maplibre, when max zoom was much lower, and people could not solve one quest as it was below other quest). Not quite the same, but some of the suggested solutions were somewhat similar IIRC.

@westnordost
Copy link
Member

Notes currently block editing elements in a radius of about 1.1 meters (on the equator, about 0.6 meters in Bremen). See https://wiki.openstreetmap.org/wiki/Precision_of_coordinates

To block only for the exact position may be problematic due to floating point imprecision. Also, IIRC the algorithm to calculate the center of a geometry once changed ever so slightly (and may in the future: #4965), which made it necessary to enlarge the area for which a note should block quest generation and editing in general.

Anyway, the change in centroid calculation has been a long time ago, so I think it is OK to go down to ~11cm (truncating to 6 decimals).

@westnordost
Copy link
Member

westnordost commented Jan 8, 2025

Ref #1089

Funny, how this issue is referenced exactly 5000 issues/PRs later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants