Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action reports success despite config load error #1897

Closed
chalin opened this issue Aug 9, 2024 · 1 comment · Fixed by #1902
Closed

Action reports success despite config load error #1897

chalin opened this issue Aug 9, 2024 · 1 comment · Fixed by #1902

Comments

@chalin
Copy link

chalin commented Aug 9, 2024

CSpell-action reported as succeeding

SPELLING check
succeeded 4 hours ago in 5s

despite a configuration error (from https://github.com/open-telemetry/opentelemetry.io/actions/runs/10317103275/job/28560650923):

Run streetsidesoftware/cspell-action@v6
cspell-action
Pull Request
Error: Configuration
        name: Configuration Loader Error
        msg: Failed to resolve configuration file: "@cspell/dict-es-es/cspell-ext.json" referenced from "./.cspell.yml"

/cc @open-telemetry/docs-maintainers @svnm @theletterf

@Jason3S
Copy link
Contributor

Jason3S commented Aug 12, 2024

@chalin,

Thank you. I agree, it should fail if there are configuration errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants