New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestEventuallyIssue805: flaky test #1411

Closed

dolmen opened this issue Jul 6, 2023 · 1 comment · Fixed by #1412

Assignees

Labels

Collaborator

dolmen commented Jul 6, 2023

We still have flaky tests. It looks like #865 did not fix everything related to #805 and #835.

$ go test -race -failfast -count 100 -run TestEventuallyIssue805 ./assert 
--- FAIL: TestEventuallyIssue805 (0.00s)
    assertions_test.go:2815: 
        	Error Trace:	
        	Error:      	Should be false
        	Test:       	TestEventuallyIssue805
FAIL
FAIL	github.com/stretchr/testify/assert	0.451s
FAIL

dolmen added bug pkg-assert labels

dolmen mentioned this issue

assert: fix TestEventuallyTimeout #1412

Merged

dolmen self-assigned this

Collaborator

brackendawson commented Jul 20, 2023

This dinged us in this PR too: https://github.com/stretchr/testify/actions/runs/5596433158/jobs/10233448218#step:4:1567

MovieStoreGuy closed this as completed in #1412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment