Check and apply configurations for controllers via Admin API #10913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
tinaselenge
changed the title
This change is targeted for a release that supports 3.9.0 or later Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
tinaselenge
force-pushed
the
configure-controllers
branch
from
f41e6ed to
36dc1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Currently, we restart controller-only nodes if there is any controller relevant configuration changes detected via Pod annotation. The reason for this was previously controller-only nodes did not provide API access. After Kafka 3.9.0 release and #10016, the operator can now talk to controller-only nodes directly via Admin API.
With this PR, KafkaRoller checks configurations and applies dynamic configurations for controllers via Admin API, which is how it's currently done for brokers. It removes the logic in KafkaReconciler for detecting controller relevant configurations via Pod annotation.
It also removes the Kafka version checks done before talking to controllers because this PR is targeted for an operator release that only supports Kafka version 3.9.0 or later.
Closes #10900
Checklist
Please go through this checklist and make sure all applicable tasks have been done