Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should reconsider network configuration #83

Closed
scholzj opened this issue Oct 13, 2024 · 0 comments · Fixed by #85
Closed

We should reconsider network configuration #83

scholzj opened this issue Oct 13, 2024 · 0 comments · Fixed by #85
Labels
enhancement New feature or request needs-triage

Comments

@scholzj
Copy link
Member

scholzj commented Oct 13, 2024

When using StrimziKafkaCluster, we seem to always create new network. That seems to lead to problems as Docker can have only a limited number of networks and when you run out of it, you get an error such as in #80. We should consider how we deal with this:

  • Add an option to configure the network to be used (e.g. shared network works around the issue in StrimziKafkaCluster.start() seems to silent criticial errors #80)
    • If we decide to do this, we should consider how to do it
      • Should we expose the Network object from Test container?
      • Should we have just some flag to (e.g. boolean sharedNetwork) to not expose TestContainer details into the user application?
      • Should an environment variable be used to avoid setting it easily differently for different environments?
  • Or should we just rely on the defaults from Test Container? The KindContainer does not seem to do anything with network (but we do not start/stop it as often as we do for the Kafka container)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant