Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Activity.onBackPressed() implementation should be replaced with OnBackPressedCallback #5951

Closed
fbarthelery opened this issue Dec 13, 2022 · 2 comments · Fixed by #6012
Assignees
Labels

Comments

@fbarthelery
Copy link

Summary

Following on #5844, if an application that uses stripe-android library has opt-in to predictive back gesture, Activity.onBackPressed() callback will not be called when user press the back button.
This will cause various bugs as some activities expect onBackPressed() to be called.
onBackPressed() implementation should be replaced with OnBackPressedCallback

Code to reproduce

Opt in to predictive back gesture, launch one of the affected activity. Press back button. onBackPressed() is not called

Android version

Android 13 api 33

SDK classes

After a quick search, I listed some implementation of onBackPressed() in the codebase:

@tillh-stripe
Copy link
Collaborator

Hi there 👋 Thanks for bringing this to our attention. We’ll improve support for the predictive back gesture behavior and include this in our next release.

@tillh-stripe
Copy link
Collaborator

Just released as part of version 20.18.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants