Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PaymentSheet Set up Button visually locked when fill all inputs #9444

Closed
aitorcooltra opened this issue Oct 15, 2024 · 8 comments
Closed
Labels

Comments

@aitorcooltra
Copy link

Summary

When you fill all inputs in the Payment Sheet, the "set up" button keeps locked visually. You can tap on the button and it works fine, but this is confused for the user.

Code to reproduce

Here a screenshot:
paysheetlocked

Android version

Android 13

kotlin: 2.0.0
stripe-android: 20.47.0
Android Gradle Plugin: 8.5.1
Gradle: 8.7-bin

SDK classes

PaymentSheet.kt

@porter-stripe
Copy link
Contributor

porter-stripe commented Oct 15, 2024

Hi @aitorcooltra we are unable to reproduce this. Could you share the code you use to configure PaymentSheet, especially the appearance?

@aitorcooltra
Copy link
Author

I do not know if this is useful for you, but the appearance is:

 private val paymentSheetAppearance = PaymentSheet.Appearance(
    colorsLight = paymentSheetThemeColors,
    colorsDark = paymentSheetThemeColors
)

 private val paymentSheetThemeColors by lazy {

    PaymentSheet.Colors.defaultLight
        .copy(
            primary = ContextCompat
                .getColor(context, R.color.color_primary)
        )
}

@jaynewstrom-stripe
Copy link
Collaborator

@aitorcooltra do you mean the "Set up" button is disabled, and nothing happens when you click it? Or are you referring to the lock icon?

@aitorcooltra
Copy link
Author

@aitorcooltra do you mean the "Set up" button is disabled, and nothing happens when you click it? Or are you referring to the lock icon?

Just the lock icon and the ripple of the button.

@jaynewstrom-stripe
Copy link
Collaborator

@aitorcooltra could you reframe this as a feature request?

Is your goal to be able to remove the lock icon, and change the ripple behavior of the button?

@aitorcooltra
Copy link
Author

@jaynewstrom-stripe Yes, because you just filled all inputs on the Bottom Sheet

@jaynewstrom-stripe
Copy link
Collaborator

The lock is supposed to represent a secure checkout experience. Not to reference that you're unable to checkout. I'll provide this feedback to the team.

Another option would be to use PaymentSheet.FlowController, which has a different UI/UX, which doesn't include the lock icon.

@wooj-stripe
Copy link
Contributor

@aitorcooltra Thank you for the suggestion! While we don't plan on building this at this time, we revisit our roadmap periodically and will keep this in mind. Please keep the ideas coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants