Merge pull request #1144 from barclayadam/master

Change StripeDateTimeConverter to write epoch not MS /Date(.)/ format

Author: brandur-stripe

src/Stripe.Tests.XUnit/_infrastructure/datetime_json_converter.cs

@@ -0,0 +1,48 @@
+using System;
+using FluentAssertions;
+using Newtonsoft.Json;
+using Stripe.Infrastructure;
+using Xunit;
+
+namespace Stripe.Tests.Xunit
+{
+    public class datetime_json_converter
+    {
+        [Fact]
+        public void should_roundtrip_datetimes()
+        {
+            var obj = new TestObject
+            {
+                Date = RoundedDate()
+            };
+
+            var reloaded = JsonConvert.DeserializeObject<TestObject>(JsonConvert.SerializeObject(obj));
+            reloaded.Date.Should().Be(obj.Date);
+        }
+
+        [Fact]
+        public void should_handle_null()
+        {
+            var obj = new TestObject
+            {
+                Date = null
+            };
+
+            var reloaded = JsonConvert.DeserializeObject<TestObject>(JsonConvert.SerializeObject(obj));
+            reloaded.Date.Should().BeNull();
+        }
+
+        private static DateTime RoundedDate()
+        {
+            var date = DateTime.UtcNow;
+
+            return date.AddTicks( -1 * (date.Ticks % TimeSpan.TicksPerSecond));
+        }
+
+        public class TestObject
+        {
+            [JsonConverter(typeof(StripeDateTimeConverter))]
+            public DateTime? Date { get; set; }
+        }
+    }
+}

src/Stripe.net/Infrastructure/JsonConverters/StripeDateTimeConverter.cs

@@ -8,7 +8,10 @@ internal class StripeDateTimeConverter : DateTimeConverterBase
     {
         public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
         {
-            writer.WriteRawValue(@"""\/Date(" + EpochTime.ConvertDateTimeToEpoch((DateTime)value).ToString() + @")\/""");
+            if (value == null)
+                writer.WriteNull();
+            else
+                writer.WriteRawValue(((DateTime)value).ConvertDateTimeToEpoch().ToString());
         }
 
         public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)